Skip to content

[core] report driver stat and add test#58045

Merged
jjyao merged 3 commits intoray-project:masterfrom
tianyi-ge:report_driver_stats
Oct 24, 2025
Merged

[core] report driver stat and add test#58045
jjyao merged 3 commits intoray-project:masterfrom
tianyi-ge:report_driver_stats

Conversation

@tianyi-ge
Copy link
Contributor

@tianyi-ge tianyi-ge commented Oct 23, 2025

Description

To include driver process, remove "ray::" cmdline prefix check for worker stats
image

Related issues

Signed-off-by: tianyi-ge <tianyig@outlook.com>
@tianyi-ge tianyi-ge requested a review from a team as a code owner October 23, 2025 15:42
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully enables the reporting of driver process statistics by removing the restrictive ray:: prefix check on the command line. The change is straightforward and is correctly validated by an updated test case that now asserts the presence of the driver process (sys.executable) in the collected component metrics. I have one suggestion to simplify the code.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Tianyi <tianyig@outlook.com>
@jjyao
Copy link
Collaborator

jjyao commented Oct 23, 2025

There are test failures

@ray-gardener ray-gardener bot added core Issues that should be addressed in Ray Core observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling community-contribution Contributed by the community labels Oct 23, 2025
@can-anyscale can-anyscale added the go add ONLY when ready to merge, run all tests label Oct 23, 2025
Signed-off-by: tianyi-ge <tianyig@outlook.com>
@jjyao jjyao merged commit 752d9cd into ray-project:master Oct 24, 2025
6 checks passed
xinyuangui2 pushed a commit to xinyuangui2/ray that referenced this pull request Oct 27, 2025
Signed-off-by: tianyi-ge <tianyig@outlook.com>
Signed-off-by: Tianyi <tianyig@outlook.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: xgui <xgui@anyscale.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
Signed-off-by: tianyi-ge <tianyig@outlook.com>
Signed-off-by: Tianyi <tianyig@outlook.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
Signed-off-by: tianyi-ge <tianyig@outlook.com>
Signed-off-by: Tianyi <tianyig@outlook.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
Signed-off-by: tianyi-ge <tianyig@outlook.com>
Signed-off-by: Tianyi <tianyig@outlook.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Future-Outlier <eric901201@gmail.com>
Blaze-DSP pushed a commit to Blaze-DSP/ray that referenced this pull request Dec 18, 2025
Signed-off-by: tianyi-ge <tianyig@outlook.com>
Signed-off-by: Tianyi <tianyig@outlook.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants